DeCarabas/oden
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Comments and a bug fix

Browse source
This commit is contained in:
John Doty 2023-06-29 10:14:10 -07:00
parent a2dafeea12
commit 3b2af4bb14
2 changed files with 11 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

19
oden-js/src/context.rs
View file

@ -278,7 +278,10 @@ impl ContextRef {
Value::from_raw(v, self)
}
/// Construct a new promise.
/// Construct a new promise. The resulting Value is the promise object
/// that can be returned to script and awaited. The Promise object is the
/// one that you can use for completions. Note that if you drop the
/// promise before completing it you *will* panic.
pub fn new_promise(&self) -> Result<(Value, Promise)> {
self.get_runtime().new_promise(self)
}
@ -362,19 +365,7 @@ impl ContextRef {
/// Process all pending async jobs. This includes all promise resolutions.
pub fn process_all_jobs(&self) -> Result<()> {
// TODO: SAFETY
// This is unsafe because multiple contexts can be sharing the same runtime and cause
// a race condition on the underlying runtime.
loop {
let mut ctx1: *mut sys::JSContext = std::ptr::null_mut();
let err = unsafe { sys::JS_ExecutePendingJob(sys::JS_GetRuntime(self.ctx), &mut ctx1) };
if err == 0 {
break;
} else if err < 0 {
return Err(ContextRef::from_raw(ctx1).exception_error());
}
}
Ok(())
self.get_runtime().process_all_jobs()
}
}